Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search within editor #219

Closed
tonythere opened this issue Dec 24, 2019 · 11 comments
Closed

Search within editor #219

tonythere opened this issue Dec 24, 2019 · 11 comments
Assignees
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.

Comments

@tonythere
Copy link

tonythere commented Dec 24, 2019

Issuehunt badges

Hello all, could anyone tell me how to search a term in the note editor? I tried Command + F and lookup in menus either but no luck.

Thank you.


IssueHunt Summary

Backers (Total: $30.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

@RyanGreenup
Copy link

The only way that I was able to make it work is if you change the keymap and use the Vim search.

  1. Go to settings Ctrl + ,
  2. Select Editor from the left side then scroll down to the 5th entry 'Editor Keymap'
  3. Select Vim
  4. Now inside the note if you press / followed by a search term and then Enter it will search for that term and you can cycle between the results with n.
    • This isn't ideal though because the search term won't be displayed anywhere, so this is a work around at best.

This would be far less of an issue if there was an implemented method to use an external editor as there is in Joplin or Notable.

@kazup01 kazup01 added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Dec 25, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Dec 25, 2019

@boostio has funded $30.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. label Dec 25, 2019
@tobifasc
Copy link
Contributor

Should we still use CodeMirror's built in search addon? It provides all the basic functionality as described here and could be activated in 5 minutes but it lead to some issues in old BoostNote (e.g. BoostIO/BoostNote-Legacy#856, BoostIO/BoostNote-Legacy#1400, BoostIO/BoostNote-Legacy#1813, BoostIO/BoostNote-Legacy#2116, BoostIO/BoostNote-Legacy#3205) which mostly arised because its functionality was not well documented and some minor usability improvements/tweaks were requested.

We could create our own search addon (just like someone did here (i haven't tested this - it's not maintained)) but that would take longer to implement.

A find/replace-widget i personally really like is the one in Monaco Editor. Is the discussion in #69 still ongoing? If yes and we switch to Monaco we could close this issue. If not we could at least take a look at their design decisions.

@Flexo013 Flexo013 changed the title How to search in editor? Search within editor Feb 15, 2020
@Flexo013 Flexo013 added feature request 🌟 Issue is a new feature request. and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Feb 15, 2020
@SannePetersNL
Copy link

Also looking for a fix, this is the main reason why I can't use boost note as my default note taking app.

@Ckbhatia
Copy link

@Flexo013 Please add the platform label, such as the android, web, etc. So, Interested developers can work accordingly.

@Flexo013
Copy link
Contributor

@Ckbhatia This issue doesn't necessarily pertain a specific platform (since you can hook up keyboards to phones as well).

@Ckbhatia
Copy link

@Flexo013 I know that. But, android developer isn't going to develop this feature for web app.

So, how do you manage that?

@Flexo013
Copy link
Contributor

We have the labels set up such that if there is no specific platform tag present then the issue pertains to a general development.

@lotdrops
Copy link

lotdrops commented Jul 6, 2020

A fix on this would be awesome, it is my main pain point with Boostnote

@Flexo013
Copy link
Contributor

@SannePetersNL @lotdrops Make sure to give a 👍 to issues you would like to see fixed or features you would like to see added. That will help with gauging how popular certain features are and what should be prioritized.

@Komediruzecki
Copy link
Contributor

Merged and waiting for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🌟 Issue is a new feature request. funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.
Projects
None yet
Development

No branches or pull requests

9 participants