exclude-file-types flag exludes aliases #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
approved these changes
Nov 9, 2024
| name: "exclude json and yaml", | ||
| input: "json,yaml", | ||
| expectedExcludeFileTypes: []string{"json", "yaml", "yml"}, | ||
| }, |
There was a problem hiding this comment.
Please add tests about these cases I reported here
|
By aliases, I meant something like the aliases you can find here https://github.com/github-linguist/linguist/blob/main/lib%2Flinguist%2Flanguages.yml I don't expect to implement everything of course. And yes, with the current file types, your implementation could be enough https://github.com/Boeing/config-file-validator/blob/main/pkg%2Ffiletype%2Ffile_type.go The only examples in the current list, I can think about is the .env, that people are more likely to call dotenv, so it could be an alias |
kehoecj
added
OSS Community Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #214
If file type is similar to one of extensions, then exclude all extensions
Before fix:
After fix:
