-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update {{ stage_name }}.qmd #33
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,22 @@ | ||
```{r} | ||
library(conflicted) | ||
library(dso) | ||
#| label: load libraries | ||
|
||
require(conflicted) | ||
require(dso) | ||
``` | ||
|
||
```{r} | ||
# Set stage dir, compile and load params | ||
#| label: read params | ||
# read_params sets the stage directory, runs 'dso compile-config' | ||
# and loads params defined in the 'dvc.yaml' 'params' section of the stage | ||
|
||
params <- read_params("{{ stage_path }}") | ||
``` | ||
|
||
```{r} | ||
# Obtain files relative to stage directory, e.g. | ||
#| label: Obtain files relative to stage directory | ||
|
||
# stage_here locates your files relative to the stage path set in read_params | ||
# e.g. | ||
samplesheet <- readr::read_csv(stage_here(params$samplesheet)) | ||
``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think label should not contain spaces as it will be a hyperlink anchor, see https://quarto.org/docs/reference/cells/cells-knitr.html#attributes
Not sure we need labels at all here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label can contain spaces, but yes, we can remove spaces.
labels are good practice, as it shows progress in compilation, also it can be used for referencing block dependencies (spaces are there no problem). it would be good to have show good practice in the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I dislike them because I forget to change them when I copy&paste a block and then compilation fails because of duplicate labels. But I agree in an ideal world one would use them.