Per-platform unique port identifiers #38
Conversation
| let mut handler_data = self.activate_callback(); | ||
|
|
||
| // Create port ... | ||
| let port = match self.client.as_mut().unwrap().register_midi_port(port_name, PortIsOutput) { | ||
| let source_port = match self.client.as_mut().unwrap().register_midi_port(port_name, PortIsOutput) { |
There was a problem hiding this comment.
The use of unwrap is disallowed in real life code. In this specific case, even when the function is returning a Result, there might be a panic, which would be breaking the contract of the function. I suggest you chain errors, or else use if let.
There was a problem hiding this comment.
Yep, that's usually true, but in this case, we know that self.client will actually never be None except between the self.client.take() in line 282 and the end of the method. And if it actually was None here, it's clearly a programming error on my side, and a panic is totally the right thing to happen then (it's a little bit like an implied assert!(self.client.is_some())).
It would be much better without using Option here, but I didn't find a way to do that when I originally wrote that code. I'll have to revisit this and see if there's a better way.
There was a problem hiding this comment.
Thanks for the explanation, I've been quite involved in functional programming lately, and couldn't avoid to see that, but your argument is completely reasonable :-P
FYI While looking for possible alternatives I learnt about the do-notation in rust here, but I haven't used it myself yet.
Boddlnagg
force-pushed
the
port-ids
branch
5 times, most recently
from
f142218 to
7b865ed
Compare
Implements #32.
This is not ready yet ... still missing:
MidiInputPortsorMidiOutputPortscollection (not possible via deref to slice)