Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Send on everything #36

Closed
kovaxis opened this issue Jan 22, 2018 · 2 comments
Closed

Implement Send on everything #36

kovaxis opened this issue Jan 22, 2018 · 2 comments
Milestone

Comments

@kovaxis
Copy link

kovaxis commented Jan 22, 2018

Hello.
I've noticed that MidiOutputConnection implements Send, and it's quite a useful feature.
However, other structs don't seem to implement it, which surprised me because MidiInputConnection is used only as a token to keep the connection alive.
Is it possible to make input connections, and for that matter the rest of the structs, implement Send, or am I missing something important that disallows this?

@Boddlnagg
Copy link
Owner

Boddlnagg commented Jan 22, 2018

Actually I had already added a comment that all the structs should implement Send:

// TODO: make sure that these structs are all `Send` and implement `Debug` (?)

I've only done it for MidiOutputConnection consistently on all the backends so far, because I needed that for one of the examples. Ideally I would want to be 100% sure that sending midi connections to other threads is actually supported by all the backends, but I don't really know of any reason why it shoudn't.

So I'm definitely going to look into this soon. Thanks for the report!

@Boddlnagg
Copy link
Owner

This has been fixed by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants