Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing data for Azure virtual machines #282

Merged
merged 78 commits into from
Sep 20, 2024
Merged

Conversation

bpetit
Copy link
Collaborator

@bpetit bpetit commented Apr 4, 2024

Hi there,

Here is a PR aggregating data to feed the API with Microsoft Azure data for virtual machines (and supposed underlying hosts).

This should not be merged until we at least clean it up (for instance, our scripts are not PEP8 at all 😋) and improve the readme (+ that it is reviewed of course), but we wanted to allow contributors to review it in advance and give feedbacks.

I hope it is not too much noise until it is clean.

kudos @bdromard and ping to join the discussion :)

@bpetit bpetit changed the title WIP: providing data for Azure virtual machines WIP (don't merge yet !): providing data for Azure virtual machines Apr 4, 2024
@bpetit
Copy link
Collaborator Author

bpetit commented Apr 8, 2024

We tried to assess how coherent the data is by comparing it to AWS instances, and are running analysis on how the different input data and hypothesis are important in the result.

So far, it seems coherent, so if anyone want to review the PR, that would be great :)

You can find results we generated for testing in results.csv and the script that generated those data in generate_impact_azure.

Let us know if we could do something more to make review easier.

Cheers

@bpetit bpetit linked an issue Apr 9, 2024 that may be closed by this pull request
- Bursts and overcommit are not accounted for, as the scripts in their current form only extract the number of vCPUs for each instance, without considering if this instance is a burstable instance. Fixing this would mean to extract informations about burst conditions for each instance and change the value of vcpus accordingly (or rely on a mecanism in BoaviztAPI that doesn't exist today).
- For GPUs (concerning NVv3 and NVv4 series): GPU units and memory for the hosts are established by matching the number of vCPUS for an instance and the number of vCPUS for the host, and establishing
the potential number of GPUs in the host with the documentation for the instances.
- Current version of the API doesn't account for remote storage. A share of the impacts of local hardware storage is allocated to the virtual machine, which makes sense. In the case of Azure data, we don't have the actual stoarage hardware and volume available for Dedicated Hosts / Bare metal machines. It means that current version of the impacts calculated by the API for Azure is **underestimated** regarding impacts of storage, as we don't account neither for remote storage nor for local storage.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a modeling discussion we might have in the next Boavizta Tools meeting, isn't it ? @demeringo @da-ekchajzer

@bpetit
Copy link
Collaborator Author

bpetit commented Apr 16, 2024

Tried to explain a bit more the perimeter covered by the api's cloud/instance route here. I'd be happy to have your feedback on this :)

bpetit and others added 18 commits April 17, 2024 16:34
del: aws vantage export, not the right folder
… from the official documentation

clean: cleaned_dedicated_hosts
fix: changed name for sorting script
…s been completed with missing or incomplete references
bpetit and others added 17 commits April 17, 2024 16:36
docs: documenting underestimated impact for storage
docs: GPU units still has to be filled for virtual machines
docs: improving readme and results.md, adding GreenPixie as sponsor, detailling life cycle steps covered

docs: improving readme and results.md, adding GreenPixie as sponsor, detailling life cycle steps covered
…emote storage

docs: adding explanation of perimeter of the cloud/instance route
docs: improving results.md

docs: improved results.md
@bpetit
Copy link
Collaborator Author

bpetit commented Apr 17, 2024

Hi @da-ekchajzer @demeringo @samuelrince,

Data generated in result.csv seem coherent, not too far from data generated for AWS instances with the same script.

I think we could procede with a global review any time you want now.

Last thing I may do, but it could be in another PR, will be to include data for instances still missing, especially A and B series.

As said in the README, we thank GreenPixie for sponsoring this PR.

@bpetit bpetit changed the title WIP (don't merge yet !): providing data for Azure virtual machines Providing data for Azure virtual machines Apr 17, 2024
@demeringo
Copy link
Collaborator

Tried to explain a bit more the perimeter covered by the api's cloud/instance route here. I'd be happy to have your feedback on this :)

Great, particularly the diagram 👍

@havontuur
Copy link

@bpetit I have looked and tried the PR and might have found a misconfiguration for 'id=Dadsv5-Type1' in server.csv.
In this PR this platform is defined with 112 vCPU and a SSD of 2400, but according the Microsoft page it should be 96 and 3600.

Am I right or do I misunderstand the configuration?

@bdromard
Copy link
Contributor

@bpetit I have looked and tried the PR and might have found a misconfiguration for 'id=Dadsv5-Type1' in server.csv. In this PR this platform is defined with 112 vCPU and a SSD of 2400, but according the Microsoft page it should be 96 and 3600.

Am I right or do I misunderstand the configuration?

Hello @havontuur !

What is indicated for Dadsv5-Type1 in server.csv (or any other Azure ID in that table) is the configuration for the dedicated host identified with this name, as documented on this page for the vCPU and the RAM specifications.

On the issue of storage, the allocation remains a problem, as we have not found reliable information on the hardware devices present on dedicated hosts yet.

Were you referring to this page from the Azure documentation on virtual machines when you were mentioning 96 vCPU and 3600 GiB of SSD storage ?

@da-ekchajzer da-ekchajzer merged commit 85fac66 into Boavizta:dev Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AZURE compute instances impacts
5 participants