Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt master key with a password before storing #28

Merged
merged 4 commits into from
Feb 10, 2024
Merged

Encrypt master key with a password before storing #28

merged 4 commits into from
Feb 10, 2024

Conversation

emjshrx
Copy link
Contributor

@emjshrx emjshrx commented Feb 3, 2024

fixes #18

theanmolsharma
theanmolsharma requested changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@theanmolsharma theanmolsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge, I want to see some tests for the functionality you are adding.
Don't merge the PR after addressing the comments, wait for at least 1 approval.

src/wallet/wallet.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Show resolved Hide resolved
src/wallet/db/db.interface.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
@emjshrx emjshrx marked this pull request as ready for review February 9, 2024 16:28
theanmolsharma
theanmolsharma reviewed Feb 10, 2024
View reviewed changes
test/wallet.spec.ts Outdated Show resolved Hide resolved
theanmolsharma
theanmolsharma requested changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@theanmolsharma theanmolsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments, then we can merge. Nice work!!

@emjshrx emjshrx merged commit ad98bdb into main Feb 10, 2024
2 checks passed
@emjshrx emjshrx deleted the encrypted-store branch February 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theanmolsharma theanmolsharma theanmolsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encrypt master key with a password before storing
2 participants
@emjshrx @theanmolsharma