Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt master key with a password before storing #18

Closed
4 tasks
theanmolsharma opened this issue Jan 6, 2024 · 0 comments · Fixed by #28
Closed
4 tasks

Encrypt master key with a password before storing #18

theanmolsharma opened this issue Jan 6, 2024 · 0 comments · Fixed by #28
Assignees
Labels
enhancement New feature or request

Comments

@theanmolsharma
Copy link
Collaborator

theanmolsharma commented Jan 6, 2024

Note: This issue is not about supporting bip39 passphrase, but about wallet encryption. The seed stored in the wallet-db should be encrypted with a password.

  • Install "@types/bip38" as dev-dependency
  • Password should be optional in init(). If no password is passed, use the default password 12345678.
  • Use "bip38" lib to do encryption/decryption.
  • Implement async setPassword(newPassword, oldPassword): void in Wallet class to add or update password
@theanmolsharma theanmolsharma added the enhancement New feature or request label Jan 6, 2024
@theanmolsharma theanmolsharma changed the title Encrypt seed when saving with a passphrase, instead of plain text Encrypt seed with a passphrase before storing, instead of plain text Jan 6, 2024
@theanmolsharma theanmolsharma changed the title Encrypt seed with a passphrase before storing, instead of plain text Encrypt seed with a passphrase before storing Jan 6, 2024
@theanmolsharma theanmolsharma changed the title Encrypt seed with a passphrase before storing Encrypt seed with a password before storing Jan 6, 2024
@theanmolsharma theanmolsharma changed the title Encrypt seed with a password before storing Encrypt master key with a password before storing Jan 6, 2024
@emjshrx emjshrx self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants