Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPS1: Fix more inconsistencies #119

Merged
merged 4 commits into from
Jul 10, 2024
Merged

LSPS1: Fix more inconsistencies #119

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef9c1d8
Move `CANCELLED` to list of `state`s
tnull Jul 9, 2024
5797ada
Add `state` to create order response
tnull Jul 9, 2024
f48b05a
Fix `address` examples
tnull Jul 9, 2024
d9bb0da
Align field ordering in examples
tnull Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions LSPS1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,16 +185,18 @@ The client MUST check if [option_support_large_channel](https://bitcoinops.org/e
"payment": {
"bolt11": {
"state": "EXPECT_PAYMENT",
"expires_at": "2015-01-25T19:29:44.612Z",
"fee_total_sat": "8888",
"order_total_sat": "2008888",
"expires_at": "2015-01-25T19:29:44.612Z",
"invoice" : "lnbc252u1p3aht9ysp580g4633gd2x9lc5al0wd8wx0mpn9748jeyz46kqjrpxn52uhfpjqpp5qgf67tcqmuqehzgjm8mzya90h73deafvr4m5705l5u5l4r05l8cqdpud3h8ymm4w3jhytnpwpczqmt0de6xsmre2pkxzm3qydmkzdjrdev9s7zhgfaqxqyjw5qcqpjrzjqt6xptnd85lpqnu2lefq4cx070v5cdwzh2xlvmdgnu7gqp4zvkus5zapryqqx9qqqyqqqqqqqqqqqcsq9q9qyysgqen77vu8xqjelum24hgjpgfdgfgx4q0nehhalcmuggt32japhjuksq9jv6eksjfnppm4hrzsgyxt8y8xacxut9qv3fpyetz8t7tsymygq8yzn05"
},
"onchain": {
"state": "EXPECT_PAYMENT",
"expires_at": "2015-01-25T19:29:44.612Z",
"fee_total_sat": "9999",
"order_total_sat": "2009999",
"expires_at": "2015-01-25T19:29:44.612Z",
"address" : "bc1p5uvtaxzkjwvey2tfy49k5vtqfpjmrgm09cvs88ezyy8h2zv7jhas9tu4y",
"address" : "bc1p5uvtaxzkjwvey2tfy49k5vtqfpjmrgm09cvs88ezyy8h2zv7jhas9tu4yr",
"min_fee_for_0conf": 253,
"min_onchain_payment_confirmations": 0
}
Expand Down Expand Up @@ -297,7 +299,7 @@ This section describes the `payment` object returned by `lsps1.create_order` and
"expires_at": "2025-01-01T00:00:00Z",
"fee_total_sat": "9999",
"order_total_sat": "200999",
"onchain_address": "bc1p5uvtaxzkjwvey2tfy49k5vtqfpjmrgm09cvs88ezyy8h2zv7jhas9tu4yr",
"address": "bc1p5uvtaxzkjwvey2tfy49k5vtqfpjmrgm09cvs88ezyy8h2zv7jhas9tu4yr",
"min_onchain_payment_confirmations": 1,
"min_fee_for_0conf": 253
}
Expand Down Expand Up @@ -338,8 +340,8 @@ The LSP MAY omit payment options.
- `HOLD` Lighting payment arrived, preimage NOT released.
- `PAID` When the has been preimage released
- `REFUNDED` Lightning payment has been refunded.
- `expires_at` <[LSPS0.datetime][]> The timestamp at which the payment option for this order expires
- `CANCELLED` Lightning payment has been cancelled
- `expires_at` <[LSPS0.datetime][]> The timestamp at which the payment option for this order expires
- `fee_total_sat` <[LSPS0.sat][]> The total fee the LSP will charge to open this channel in satoshi.
- `order_total_sat` <[LSPS0.sat][]> What the client needs to pay in total to open the requested channel.
- MUST be the `fee_total_sat` plus the `client_balance_sat` requested in satoshi.
Expand Down