Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPS1: Fix more inconsistencies #119

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 9, 2024

We fix more inconsistencies that were introduced as part of #101.

tnull added 4 commits July 9, 2024 11:44
.. as it somehow was added under `expires_at`
.. as one of the addresses failed to decode and we still had an example
with an `onchain_address` field.
Copy link
Collaborator

@SeverinAlexB SeverinAlexB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insta merge?

@tnull
Copy link
Contributor Author

tnull commented Jul 9, 2024

Insta merge?

Think so?

@SeverinAlexB SeverinAlexB merged commit 9a9ac6b into BitcoinAndLightningLayerSpecs:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants