frontend/coin-control: add address reuse warning #2724
Conversation
| {utxo.address} | ||
| </span> | ||
| <div> | ||
| <Status hidden={!hasAddressReuse} type="warning" className="m-bottom-default"> |
There was a problem hiding this comment.
This code is repeated for each utxo's script type (see image). It should be at an upper level, I guess.
strmci
force-pushed
the
coincontrol
branch
4 times, most recently
from
bebb863 to
c3a2cd2
Compare
PTAL
|
| @@ -56,6 +58,7 @@ export const UTXOs = ({ | |||
| const { t } = useTranslation(); | |||
| const [utxos, setUtxos] = useState<TUTXO[]>([]); | |||
| const [selectedUTXOs, setSelectedUTXOs] = useState<TSelectedUTXOs>({}); | |||
| const [showAddressReusedMessage, setShowAddressReusedMessage] = useState(0); | |||
There was a problem hiding this comment.
nit: I find the name of this const slightly misleading. Maybe smth like selectedReusedAddresses? Since it is a number and not a bool.
There was a problem hiding this comment.
Updated to reusedAddressUTXOs.
I'll take a look, ideally badge would be nice and inline with text. Not sure yet what causes this. |
strmci
force-pushed
the
coincontrol
branch
3 times, most recently
from
c4b34db to
dc0e54e
Compare
tl;dr it was a combination of inconsitent line-heights (parent element) and vertical centering. branch with fix @strmci @Beerosagos let me know if you want to merge this PR first and if I should open a followup PR or feel free to chery-pick my commit into this change. |
|
@thisconnect |
Add a warning to the coin control modal when a user selects one or more UTXOs from reused addresses. The warning: "One or more UTXOs have a reused address. Be aware the receiver will see all UTXOs associated with those addresses." The UTXOs now have red badge when their address was re-used.
Badges are not vertically aligned consistently in all places. This was caused mostly as badges were centerd vertically but then had slightly different line-height. Badges behave like text and usually have `display: inline;`. Changed line-height to be consistent and vertical alignment to baseline, so that the badge text stands on the same line as the other text. Badges currently appear in the following components: - account selector can have badge with icon only - sidebar shows badge for connected keystore with icon and text - reused utxo's in coincontrol have badge with warning text - account summary balance have badge for connected keystore - exchange options show best-deal or fast badge - manage-accounts shows badge for connected keystore
Add a warning to the coin control modal when a user selects one or more UTXOs from reused addresses. The warning: "One or more UTXOs have a reused address. Be aware the receiver will see all UTXOs associated with those addresses."
The UTXOs now have red badge when their address was re-used.