backend: update coin control outputs sorting #2605
Conversation
strmci
force-pushed
the
coincontrol_utxo_sort
branch
from
b188d2c to
3a19b45
Compare
|
@thisconnect thanks, I updated the commit message, PTAL |
|
Before this change the sorting was outputs by amounts. Now with this change it is outputs grouped by address then sorted by amounts. For users that didn't re-use addresses nothing should change. For users that did reuse address the list should change so that all UTXO's of the same address are shown together. I think it would be great if there is a banner on top that shows "Warning: some addresses were re-used" or similar (banner of shame). |
backend/coins/btc/account.go
Outdated
| for _, output := range outputs { | ||
| sum += output.TxOut.Value | ||
| } | ||
| sums = append(sums, struct { |
There was a problem hiding this comment.
nit: I don't like it much defining the struct twice. Maybe it is better to define it once with a proper private name outside the function.
There was a problem hiding this comment.
I added a new type addressOutputsSum and used it in the function.
strmci
force-pushed
the
coincontrol_utxo_sort
branch
from
3a19b45 to
fbd0f40
Compare
Currently, the list of all UTXOs in the coin control selection is ordered by amount. Users sometimes re-use addresses and are not aware that there might be other UTXOs they didn't want or want to use on the same address as their selected output. Grouping the UTXOs by address helps the user to detect if there are other UTXOs. This commit updates the sorting of outputs in the coin control dialog and is now grouped by address from the biggest to the lowest amount.
strmci
force-pushed
the
coincontrol_utxo_sort
branch
from
fbd0f40 to
6e60ac7
Compare
Would you like to add it here, or should we do it in a separate PR? |
|
I think separate PR makes sense or at least separate commit. For example in the case we need to undo one of the 2 changes. |
|
PR to add address reuse warning: #2724 |
Currently, the list of all UTXOs in the coin control selection is ordered by amount. Users sometimes re-use addresses and are not aware that there might be other UTXOs they didn't want or want to use on the same address as their selected output. Grouping the UTXOs by address helps the user to detect if there are other UTXOs.
This commit updates the sorting of outputs in the coin control dialog and is now grouped by address from the biggest to the lowest amount.