Tweak order of arguments supplied to distinct()
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development branch merge
To prevent behaviour change. As of dplyr 1.1.0, `distinct()` now returns arguments in the order supplied rather than in data order.
AARON-CLARK
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dplyr 1.1.0, distinct() now returns variables in the supplied order rather than the data order. This causes one of your tests to fail. This PR fixes this by reordering the supplied variables to make the test pass again.
I've also noticed that some of your join calls now cause a warning about multiple matches. You can silence these warnings by supplying
multiple = "all"where appropriate. Note that the warnings only show up in testthat and will not inconvenience your users.See the changelog for more information: https://dplyr.tidyverse.org/dev/news/index.html
We plan to release dplyr 1.1.0 to CRAN on January 27. If possible on your side, a pre-emptive patch release of tidyCDISC would be helpful. Thanks!