Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time visualization not displaying correctly #148

Open
Jeff-Thompson12 opened this issue Jan 17, 2023 · 5 comments
Open

Time visualization not displaying correctly #148

Jeff-Thompson12 opened this issue Jan 17, 2023 · 5 comments

Comments

@Jeff-Thompson12
Copy link
Collaborator

The table and plot in the individual explorer or not displaying correctly. The plot does not update it's access when additional events are selected. And the summary table does not have the data in the correct columns.

image

@AARON-CLARK
Copy link
Collaborator

@Jeff-Thompson12, but you're right about the table - it's clearly out of order but after a quick test, the timevis object does appear to update when checkboxes are clicked. The timevis object just resetting it's "zoom" custom start and end times we auto-choose when each checkbox is clicked. You just need to zoom out (as seen below) to see the full picture. This feature can be refactored, but originally, we were testing this on other data sets besides CDISC Pilot data, which didn't have the "date of disease onset", which unfortunately will be years before the first treatment is received, creating a massive time gap where nothing happens. The auto zoom was engineered to prevent the plot from exploding to something enormously tall as seen below. We could re-think it so that it auto-zooms to another timeframe that is inclusive of more events.

image

@AARON-CLARK
Copy link
Collaborator

@Jeff-Thompson12, order of columns was influenced by #144. We should probably make that change!

@AARON-CLARK
Copy link
Collaborator

@Jeff-Thompson12, order of columns was influenced by #144. We should probably make that change!

Just kidding. I jumped the gun on that one. That version of dplyr hasn't hit CRAN yet, so that's not the problem. I retract my statement.

@Jeff-Thompson12
Copy link
Collaborator Author

@AARON-CLARK Sorry, when I was investigating the issue, I realized that the changing window for the chart was intended behavior. I will probably push a PR for the table of events issue today.

@AARON-CLARK
Copy link
Collaborator

Discussed 1/26 to include a date slider for users to manipulate the visual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants