Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAE does not support experiments with BiocFrame col_data #13

Closed
DiDeoxy opened this issue Sep 19, 2023 · 1 comment
Closed

MAE does not support experiments with BiocFrame col_data #13

DiDeoxy opened this issue Sep 19, 2023 · 1 comment

Comments

@DiDeoxy
Copy link

DiDeoxy commented Sep 19, 2023

if set(rows["colname"].tolist()) != set(gcol_data.index.tolist()):

MAE also does not support BiocFrame col_data (you'll have to fix all the type hinting as well):

_sample_diff = _sample_set.difference(col_data.index.tolist())

Prolly other issues related to BiocFrame, not bother ing to find them all.

@jkanche
Copy link
Member

jkanche commented Jan 3, 2024

I believe with #17 merged, this is not necessary anymore. Please reopen if the issue persists.

@jkanche jkanche closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants