Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that error messages are always legible #78

Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: ensure that error messages are always legible #78

merged 1 commit into from
Sep 13, 2022

Conversation

Kirpal
Copy link
Collaborator

@Kirpal Kirpal commented Sep 9, 2022

Description

Fixes #63. The reason that error messages aren't legible in platform tests right now is that by default they try to use the 'monospace' font but we aren't loading a font for that by default, and Ahem is the fallback. I fixed it by changing the font family to Roboto for error widgets.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #78 (61779e7) into main (c5d14b8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          555       556    +1     
=========================================
+ Hits           555       556    +1     
Impacted Files Coverage Δ
lib/src/golden_test.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kirpal Kirpal merged commit 0cc2a37 into main Sep 13, 2022
@Kirpal Kirpal deleted the fix/63 branch September 13, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: ensure that error messages are always legible
2 participants