Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: ensure that error messages are always legible #63

Closed
1 task done
alestiago opened this issue Jun 6, 2022 · 3 comments · Fixed by #78
Closed
1 task done

request: ensure that error messages are always legible #63

alestiago opened this issue Jun 6, 2022 · 3 comments · Fixed by #78
Assignees

Comments

@alestiago
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

I would like to be able to read the error message from the golden file.

Description

As a developer, I would like to be able to read the error message from a golden file.

Reasoning

Allowing to view the error message from the golden file facilitates debugging and, hence makes the DX much nicer.

For example, the following image should have the error shown in a legible font (not Ahem):
Screenshot 2022-06-06 at 11 20 12

Additional context and comments

No response

@jeroen-meijer
Copy link
Collaborator

Thanks for reporting this!

Looks like our blocked font renderer works a little too well. We'll have a look!

@jeroen-meijer
Copy link
Collaborator

@Kirpal Do you happen to know if it's easy for us to disable the blocked text renderer AND our font mechanics when an error occurs?

@Kirpal
Copy link
Collaborator

Kirpal commented Jun 14, 2022

We could probably update the painting context to change how we render the error render object. However, I'm wondering how useful that is because you could also use the platform golden to see the message. If someone were to commit a golden with rendering issues, then the ci golden test would fail with font inconsistencies which seems undesirable. Nevermind, this was in the platform golden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants