fix: make repo, user and branch url safe #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahrmichael
changed the title
|
@BetaHuhn Could we get your eyes on this? |
|
|
|
This PR is not stale. |
|
Thank you :) |
schupryna
pushed a commit
to schupryna/deploy-to-vercel-action
that referenced
this pull request
Apr 24, 2024
* fix: slugify repo and branch * chore: linting * fix: param case user * chore: comment * chore: comment * chore: formatting * feat: output unique deployment url * fix: get deployment url with protocol * feat: handle long branch urls * feat: add logging * chore: debug * feat: logs * fix: must be 63 chars * fix: b64url * fix: b64url * fix: digest to hex * chore: info to warning * chore: remove editorconfig and prettier file * chore: update lockfile * chore: add back action-input-parser * chore: improve regex * chore: cleanup --------- Co-authored-by: Josh Barr <[email protected]>
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #184
This PR makes sure that the params repo, user and branch are url safe, due to problems explained in the original PR. I used https://perishablepress.com/stop-using-unsafe-characters-in-urls as a source of what's URL safe and what's not, and then added an inverted regex to only keep relevant characters.