Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert repo, user and branch to param-case #184

Closed
wants to merge 17 commits into from

Conversation

JoshBarr
Copy link
Contributor

👋 hey, thanks for writing this great library!

I encountered an issue if my repository contained a . character, for instance mysite.com. The output URL would be mysite.com-1234.vercel.app, which isn't a valid domain.

I also encountered an issue if my branch contained a / character, for instance ci/pipeline. The output would be myrepo-ci/pipeline.vercel.app, which isn't a valid domain either.

This PR imports paramCase from change-case and converts these values into URL-safe equivalents.

Copy link
Owner

@BetaHuhn BetaHuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please remove the editorconfig and the prettier file.

Also, making the values URL safe seems like something a simple regex could do without the need to add a new dependency.

@BetaHuhnBot
Copy link
Collaborator

⚠️ This PR has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.

@BetaHuhnBot BetaHuhnBot added the wontfix This will not be worked on label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants