-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert repo, user and branch to param-case #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you please remove the editorconfig and the prettier file.
Also, making the values URL safe seems like something a simple regex could do without the need to add a new dependency.
|
👋 hey, thanks for writing this great library!
I encountered an issue if my repository contained a
.
character, for instancemysite.com
. The output URL would bemysite.com-1234.vercel.app
, which isn't a valid domain.I also encountered an issue if my branch contained a
/
character, for instanceci/pipeline
. The output would bemyrepo-ci/pipeline.vercel.app
, which isn't a valid domain either.This PR imports
paramCase
fromchange-case
and converts these values into URL-safe equivalents.