-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameWorlds and GameModes #415
Conversation
Conflicts: src/main/java/world/bentobox/bentobox/managers/SchemsManager.java
Removes debug from previous commit. Relates to #415
I had a go at the implementation so please have a look at it and let me know what you think. It's okay to criticize! I'm not sure if I got it right. A few comments:
Merry Christmas! |
Easy comparison link: develop...gameworlds-and-gamemodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I cannot approve nor request changes as I'm the PR's author. But yet, I approve the merge of this PR.
There is a conflict with SchemsManager. Does this PR supports the multiple-schems that were added recently? |
Let me resolve the conflicts. |
See #408.
I just started the branch by creating an UML Class Diagram, which I'd like us to review before I start working on this - and so we are actually 100 % about what's going to change.