Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players should not take fall damage when switching between game worlds #420

Closed
BONNe opened this issue Dec 27, 2018 · 7 comments
Closed
Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@BONNe
Copy link
Member

BONNe commented Dec 27, 2018

Description
If a player falls in SkyBlock, and while falling writes /ai, then he takes fall damage in AcidIsland.

Steps to reproduce the behavior:

  1. Go to Skyblock.
  2. Jump in the void.
  3. While falling, write /ai

Expected behavior
The user should not take fall damage when he joins other worlds.

Movie
https://drive.google.com/file/d/18FU1u0omhttTGCowz9Yzbtzd4RLHZsya/view?usp=sharing

Server Information:

  • YAML
  • MacOS and Windows
  • Java Version: Java 8
  • :D Bentobox version: 1.0-SNAPSHOT
    Loaded Game Worlds:
  • AcidIsland_world (AcidIsland) AcidIsland 0.5.0
  • BSkyBlock_world (BSkyBlock) BSkyBlock 0.6.0

Additional context
I found it while testing #419 pull request.

@Poslovitch
Copy link
Member

Do the player takes fall damage when he falls into the void and types /is ?

@Poslovitch Poslovitch added Status: Under investigation Investigating the interest and the feasability of the issue. Status: Need answer Waiting for more information to be provided by the issue's author. labels Dec 27, 2018
@BONNe
Copy link
Member Author

BONNe commented Dec 27, 2018

Do the player takes fall damage when he falls into the void and types /is ?

Yes

@Poslovitch
Copy link
Member

Poslovitch commented Dec 27, 2018

So is that more like a feature request: remove fall damage when teleporting to an island ?

@BONNe
Copy link
Member Author

BONNe commented Dec 27, 2018

No, fall damage should not be applied to a user, if he goes from Skyblock to AcidLand and via-versa.
But if a user is falling in Skyblock, and teleports still inside Skyblock /is go ... then damage should be applied.

@Poslovitch
Copy link
Member

Hmmm. I see.
However, that may appear to be "weird" to some users. What do you think @tastybento?

@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Tweak 🖥️ and removed Status: Need answer Waiting for more information to be provided by the issue's author. Type: Enhancement Improvement or modification which is usually a new feature. labels Dec 27, 2018
@tastybento
Copy link
Member

I think this makes sense. The add-ons may want to do this themselves though by using a worldchangevent listener and removing velocity and fall ticks because it could be entirely valid that momentum should continue when you teleport in other circumstances.

I'd say this is a request on AcidIsland and BSkyBlock respectively.

@BONNe
Copy link
Member Author

BONNe commented Dec 27, 2018

You have suggested to implement GameMode addon. #415

If its approved and implemented, I think it would be better there, as these changes should be equal in all addons, that works with new worlds.

@Poslovitch Poslovitch changed the title Fall Damage on Changing world. Players should not take fall damage when switching between game worlds Jan 12, 2019
@Poslovitch Poslovitch added Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Enhancement Improvement or modification which is usually a new feature. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Declined Feature request or tweak that has been declined due to its difficulty or poor feasibility/interest. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants