-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PREVENT_TELEPORT_WHEN_FALLING flag (WORLD_SETTING) #419
Conversation
That's right, once the flag is enabled, the player cannot us /is go when falling. When they go to a different world, it'll just ignores that part - except if the command they're using is from, e.g. AcidIsland. |
To clarify my #403 comment.
I know, that it could be hard to check it, as you must teleport user to save space on world joining, so maybe, instead of checking if a player is falling you can add "timer" for teleport commands. So all teleport commands are allowed only when a caller is standing still for X seconds. |
Please create an issue for this bug, that's going to be worth investigating. |
So I tested this, with PREVENT_TELEPORT_WHEN_FALLING: true, and it is not working. |
src/main/java/world/bentobox/bentobox/api/commands/island/IslandGoCommand.java
Outdated
Show resolved
Hide resolved
Yes, I tested it and now it works. |
That is to ensure an easier maintenance process.
Great. Just waiting for the CI to do the checks before merging. Thanks for your reviews and your help 👍 |
Relates to #403.
I'm not sure if that's the best way to implement this though. So, I'd be glad to get as much feedback as possible (@BONNe).
By the way, handling this kind of thing is a bit tricky, so, if you wanna do some tests (which I'd also be glad, as I don't feel like testing right now), here is the build containing the changes:
bentobox-1.0-SNAPSHOT-TEST403.zip (just extract the .jar from the .zip archive).