Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stool changes and fixes #11281

Closed
wants to merge 11 commits into from
Closed

Stool changes and fixes #11281

wants to merge 11 commits into from

Conversation

ClownMoff
Copy link
Contributor

@ClownMoff ClownMoff commented Aug 2, 2024

About The Pull Request

Makes all stools buckeable. Also fixes the direction and type used on the bars. Since the merging of the new directional types for stools, a lot of them in current maps face the wrong direction. This PR doesn't fix the stools in BoxStation, that will be done in #11219 since fixing it here would fuck that PR for the third time

Examples of errors

imagen

imagen

imagen

Why It's Good For The Game

It's mad annoying when you are sitting on the bar and people move you around, a chair is a chair, makes no sense making this distinction. It also looks so much better because it looks like you are actually sitting when looked from behind

Testing Photographs and Procedure

Screenshots&Videos

imagen

imagen

Changelog

🆑 Varo
tweak: You can now buckle to stools
tweak: Fixes the direction and the type of stools in all maps except BoxStation
add: Missing stools in maps
/:cl:

@XeonMations
Copy link
Contributor

Can you shove people off of them?

@ClownMoff
Copy link
Contributor Author

No, you need to unbuckle them

@ClownMoff ClownMoff changed the title Makes you able to buckle on stools Stool changes and fixes Aug 2, 2024
@github-actions github-actions bot added the Mapping DMM Change label Aug 2, 2024
Copy link

github-actions bot commented Aug 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Aug 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too much to ask that it be possible to shove people out of stools since you are not literally buckling yourself to them?

@ClownMoff
Copy link
Contributor Author

ClownMoff commented Aug 9, 2024

I'm adding a 50/50 chance of getting shoved off, as proposed by Pigeon

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Sprites Sound Administration TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 and removed Merge Conflict labels Sep 6, 2024
@ClownMoff
Copy link
Contributor Author

I screwed up the PR, lovely.

@github-actions github-actions bot removed Administration TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Sep 6, 2024
Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClownMoff ClownMoff closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants