-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BoxStation Areas Reworks and Fixes #11219
Conversation
Morgue might need the external door into the hallways for Cooks/Dets/Chaplain IMO I feel like Chef might not have enough space in a table, the advantage of the current Box Kitchen is that more or less you can juggle around having an area for ingredients, raw stuff and finished products for exposure to the crew(if you don't choose to put everything on the main counter) with your new one i feel like everything would be too messy, other than that looks good! |
If you think about it, why would a station have the room where they put corpses with a door facing the open public |
I mean, on one side.. it's not a see-through window, it's a door behind access if you nitpick with that thinking a lot of things will be very "???" On the other side, a lot of stations already have that style of morgue, Box being one of the most iconic ones where you can access from the hallway, others share that while others use a backroom in maintenance Finally, i believe it's intended gameplay for the aforementioned jobs and to give antags an opportunity to do things without being caught immediatly but without being necessarily "free" either, they still need to hack in, all in all just consistency pretty much! |
A surprising amount of roles has Morgue access. I recently learnt that the RD has it for whatever reason... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cabling errors
disposals error
light clipping into the boxes here. do try to avoid having lights on wallmounts!
conflict marker (chairtable)
double trouble
it floats
avoid stacking wallmounts
light + stacked mounts
now, whats going on here? (i wont comment on all the lights on wallmounts but. you get the gist)
double trouble
it floats
double trouble
oh me oh my
stacked mounts, two cameras, in walls
triple trouble plus double trouble
AND NO APC!!!
stray cabling. already a apc in here.
these issues are everywhere, though i understand why :p just thought i'd point out a couple to help out
The issues are there because the freeze fucked everythign up, most of the stuff that is pointed out by @spockye is product of the many merge conflicts, even missplaced disposals and stuffl like that. Also you need to fuck off and stop coming to my PRs to shit on my and what I do |
Are you using mapmerge to merge the maps? |
nO |
You should be, otherwise you will have a terrible time with things being merged incorrectly. You can find it in the tools subfolder of the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the new directional wallmounts!
move this light. people WILL burn their hands, using the machine and storage
two wallmounts stacked
posters should ALWAYS be +-32
apc under poster. i dont like the diskette box being on the computer. try moving the maint door one down, and adding another table or something.
random decal
mabye break this up with a wall? not a huge fan of a all glass wall going into maintenance.
didnt check everything. look it over one more time pretty please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix the broken decalling
- fix the holodeck
- replace ALL the autoname cameras with directional
- fix the overlapping wallmounts
- fix the broken viro posters
- fix the broken flooring at the theatre stage
- fix floating light in kitchen
Look in discord for the rest of the review.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Just saw a floating shutter in the bar, and a floating air alarm in botany maint |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it should be all good to go, approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About The Pull Request
Reworks and fixes some outdated Box shenanigans:
Second attempt of #10942
Why It's Good For The Game
BoxStation is old and clunky
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 Varo, Bombyy, PigeonVerde
tweak: BoxStation: Reworked the service area and maintenance
tweak: BoxStation: Reworked the medbay area and maintenance
add: BoxStation: a room for the psychiatrist in medbay
tweak: BoxStation: fixed chaplain backroom having a weird shape
add: BoxStation: Added a new area, apc and air alarm for the captain room
fix: BoxStation: Fixes floating cameras and doble pipes and cables errors
fix: BoxStation: Fixes stools directions and types
/:cl: