-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve composer.json and travis tests #57
Conversation
- make dependencies explicit - remove compatibility with unmaintained symfony versions - define branch alias - remove bin config as the binaries from this package are only proxies and do not need to be exposed in other apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 thanks for the PR
LGTM
TODO: fix test for M6WebAmqpExtension with symfony 4+ as the service are private the tested service gets removed
indeed 👍
fact is that we're trying to move from atoum to phpunit (since Symfony is "recommending" the use of phpunit in its ecosystem), so maybe we could also use phpunit in this project too (don't know if it could help)
anyway, the Travis build shows that php7.0
and php7.1
are green, so I think this PR doesn't break anything
…vate the tested service gets removed
… and removed sf component event class
@Oliboy50 this is ready. tests pass. see also my last point in the original description. you could merge this and release it as a new patch release. then the next step would be to support SF 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you again 👏
i'm still not convinced about the .gitattributes
file, but I think it won't hurt anyway 👌
I'll let (at least) one of my colleagues approve, merge and release your PR
(the M6Web review policy requires at least 2 approvals before merging)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 👏 👍
Thanks a lot
/Dockerfile export-ignore | ||
/docker export-ignore | ||
/docker-compose.yml export-ignore | ||
/travis export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By curiosity, in which case is it interesting to prevent the export of these files? 🤔
Is it to provide lighter composer package? If so, what about src/AmqpBundle/Tests/
?
Just wondering 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release v3.1.2 |
load
on the extension like https://github.com/FriendsOfSymfony/FOSUserBundle/blob/a9e71b6e7b61e7f39ba77436ba3e9af954450c4b/Tests/DependencyInjection/FOSUserExtensionTest.php#L112-L115