Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated getException on Event #54

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix deprecated getException on Event #54

merged 1 commit into from
Mar 10, 2020

Conversation

maximecolin
Copy link
Contributor

@maximecolin maximecolin commented Feb 7, 2020 •
edited
Loading

Fix the following deprecated :

The "Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent::getException()" method is deprecated since Symfony 4.4, use "getThrowable()" instead.

The if (method_exists($event, 'getThrowable')) { keep compatibility with Symfony < 4.4.

Oliboy50
Oliboy50 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂

@Oliboy50
Copy link
Member

Oliboy50 commented Feb 7, 2020

@b-viguier is it possible to "activate" this repository on travis side, plz?

Capture d’écran 2020-02-07 à 13 43 28

@b-viguier
Copy link
Contributor

CI should be activated now…

@b-viguier
Copy link
Contributor

b-viguier commented Feb 11, 2020 •
edited
Loading

I'm closing/reopening the PR to enable CI

@b-viguier b-viguier closed this Feb 11, 2020
@b-viguier b-viguier reopened this Feb 11, 2020
@Oliboy50
Copy link
Member

thank you
maybe we could make another PR to fix the travis build
(I'd suggest to take this PR as an example)

@b-viguier
Copy link
Contributor

I made a quick distinct PR to fix build => #56

@b-viguier
Copy link
Contributor

Closing/Re-opening PR to launch CI since #56 is now merged

@b-viguier b-viguier closed this Feb 17, 2020
@b-viguier b-viguier reopened this Feb 17, 2020
@b-viguier b-viguier merged commit 3fc4f95 into BedrockStreaming:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-viguier b-viguier b-viguier approved these changes

@Oliboy50 Oliboy50 Oliboy50 approved these changes

@Siwayll Siwayll Siwayll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximecolin @Oliboy50 @b-viguier @Siwayll