Closes #3855: refactor boolReductionMsg #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3855-refactor-boolReductionMsg
branch
6 times, most recently
from
bc01454 to
421ea95
Compare
ajpotts
force-pushed
the
3855-refactor-boolReductionMsg
branch
2 times, most recently
from
e7bd8d9 to
c19f347
Compare
ajpotts
requested review from
stress-tess,
jeremiah-corrado,
jaketrookman and
drculhane
ajpotts
force-pushed
the
3855-refactor-boolReductionMsg
branch
from
c19f347 to
d0b8307
Compare
jeremiah-corrado
approved these changes
Nov 4, 2024
ajpotts
force-pushed
the
3855-refactor-boolReductionMsg
branch
from
d0b8307 to
578cd30
Compare
jaketrookman
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors boolReductionMsg, splitting it into separate
all,any,isSorted, andisSortedLocallyfunctions. It also refactors the reduction functionspdarrayclassto add theaxisandkeepdimsarguments.Closes #3855: refactor boolReductionMsg
Closes #3836: keepdims argument for sum