clean up mypy

Bears-R-Us · Nov 4, 2024 · e7bd8d9 · e7bd8d9
1 parent 2db3f5f
commit e7bd8d9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 52 deletions.
diff --git a/arkouda/pdarrayclass.py b/arkouda/pdarrayclass.py
@@ -31,66 +31,40 @@
 
 if TYPE_CHECKING:
 
-    def sum(
+    def numeric_reduce(
         pda,
         axis: Optional[Union[int, Tuple[int, ...]]] = None,
         keepdims: bool = False,
     ) -> Union[numpy_scalars, pdarray]:
         pass
 
-    def prod(
-        pda,
-        axis: Optional[Union[int, Tuple[int, ...]]] = None,
-        keepdims: bool = False,
-    ) -> Union[numpy_scalars, pdarray]:
-        pass
-
-    def max(
-        pda,
-        axis: Optional[Union[int, Tuple[int, ...]]] = None,
-        keepdims: bool = False,
-    ) -> Union[numpy_scalars, pdarray]:
-        pass
-
-    def min(
-        pda,
-        axis: Optional[Union[int, Tuple[int, ...]]] = None,
-        keepdims: bool = False,
-    ) -> Union[numpy_scalars, pdarray]:
-        pass
+    sum = numeric_reduce
+    prod = numeric_reduce
+    max = numeric_reduce
+    min = numeric_reduce
 
-    def is_sorted(
-        pda, axis: Optional[Union[int, Tuple[int, ...]]] = None, keepdims: bool = False
-    ) -> Union[bool_scalars, pdarray]:
-        pass
-
-    def is_locally_sorted(
-        pda, axis: Optional[Union[int, Tuple[int, ...]]] = None, keepdims: bool = False
-    ) -> Union[bool_scalars, pdarray]:
-        pass
-
-    def any(
+    def boolean_reduce(
         pda, axis: Optional[Union[int, Tuple[int, ...]]] = None, keepdims: bool = False
     ) -> Union[bool_scalars, pdarray]:
         pass
 
-    def all(
-        pda, axis: Optional[Union[int, Tuple[int, ...]]] = None, keepdims: bool = False
-    ) -> Union[bool_scalars, pdarray]:
-        pass
+    is_sorted = boolean_reduce
+    is_locally_sorted = boolean_reduce
+    all = boolean_reduce
+    any = boolean_reduce
 
 
-__all__ = [  # noqa: F822
+__all__ = [
     "pdarray",
     "clear",
-    "any",  # noqa: F822
-    "all",  # noqa: F822
-    "is_sorted",  # noqa: F822
-    "sum",  # noqa: F822
+    "any",
+    "all",
+    "is_sorted",
+    "sum",
     "dot",
-    "prod",  # noqa: F822
-    "min",  # noqa: F822
-    "max",  # noqa: F822
+    "prod",
+    "min",
+    "max",
     "argmin",
     "argmax",
     "mean",
@@ -118,7 +92,7 @@ def all(
     "RegistrationError",
     "broadcast_to_shape",
     "_to_pdarray",
-]  # noqa: F822
+]
 logger = getArkoudaLogger(name="pdarrayclass")
 
 SUPPORTED_REDUCTION_OPS = ["any", "all", "isSorted", "isSortedLocally", "max", "min", "sum", "prod"]

diff --git a/src/registry/reduction_script.py → src/scripts/generate_reduction_functions.py b/src/registry/reduction_script.py → src/scripts/generate_reduction_functions.py
@@ -6,7 +6,7 @@
 ]
 
 
-def generate_function():
+def generate_reduction_functions():
 
     ret = """module ReductionMsgFunctions
 {
@@ -60,15 +60,10 @@ def generate_function():
 
 def main():
 
-    infile = "src/ReductionMsg.chpl"
-
-    x = generate_function()
-    print(x)
-
     outfile = "src/ReductionMsgFunctions.chpl"
 
     with open(outfile, "w") as text_file:
-        text_file.write(x)
+        text_file.write(generate_reduction_functions())
 
 
 if __name__ == "__main__":