Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Commands.chpl from tree #3799

Merged

Conversation

jeremiah-corrado
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado commented Sep 30, 2024

Stop tracking src/registry/Commands.chpl. This makes the chapel-py library a hard requirement for building Arkouda.

@jeremiah-corrado jeremiah-corrado marked this pull request as draft September 30, 2024 15:10
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! thanks! The one thing is I think it's worth noting this dependency in the usual requirement places (might need to be a comment in the yamls to keep conda from trying to find it)

You can reference this PR to see the files I tend to update for requirement/dependency changes

@jeremiah-corrado jeremiah-corrado marked this pull request as ready for review October 9, 2024 13:57
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stress-tess stress-tess added this pull request to the merge queue Oct 9, 2024
Merged via the queue into Bears-R-Us:master with commit a1e2bd4 Oct 9, 2024
11 checks passed
@jeremiah-corrado jeremiah-corrado deleted the remove-Commands-file branch October 10, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants