Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3823 flatten function to match numpy #3825

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Closes #3823 flatten function to match numpy #3825

merged 2 commits into from
Oct 10, 2024

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Oct 9, 2024

This adds a flatten function to match numy:
https://numpy.org/doc/2.0/reference/generated/numpy.ndarray.flatten.html

Addition of an order argument is left to a separate ticket: #3824

Closes #3823 flatten function to match numpy

@ajpotts ajpotts force-pushed the 3823-flatten-function-to-match-numpy branch from 3be675b to 518ee01 Compare October 10, 2024 00:33
@ajpotts ajpotts marked this pull request as ready for review October 10, 2024 14:04
jeremiah-corrado
jeremiah-corrado approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jeremiah-corrado jeremiah-corrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad to see that registerCommand just worked on the existing proc.

src/registry/Commands.chpl Outdated Show resolved Hide resolved
@ajpotts ajpotts force-pushed the 3823-flatten-function-to-match-numpy branch from 5837c42 to 2cbfa51 Compare October 10, 2024 14:28
@ajpotts ajpotts force-pushed the 3823-flatten-function-to-match-numpy branch from 2cbfa51 to 141aebb Compare October 10, 2024 14:29
stress-tess
stress-tess approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks

@stress-tess stress-tess enabled auto-merge October 10, 2024 14:36
jaketrookman
jaketrookman approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@stress-tess stress-tess added this pull request to the merge queue Oct 10, 2024
Merged via the queue into Bears-R-Us:master with commit 4382a47 Oct 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketrookman jaketrookman jaketrookman approved these changes

@jeremiah-corrado jeremiah-corrado jeremiah-corrado approved these changes

@stress-tess stress-tess stress-tess approved these changes

@drculhane drculhane Awaiting requested review from drculhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flatten function to match numpy
4 participants
@ajpotts @stress-tess @jeremiah-corrado @jaketrookman