-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3699 zeros, ones, full to return Array #3701
Closes #3699 zeros, ones, full to return Array #3701
Conversation
a1b3e70
to
817f357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the motivation for importing the array-api module into arkouda propper to implement the multi-dim stuff. I would have thought that doing things the other way around would make more sense (i.e., make arkouda-propper support multi-dim pdarrays natively, and then build the Array API module on top of that (or, leave the Array API module as a separate thing for now)).
My mental model for the array-api module was for Array
to be a thin wrapper around a pdarray
that implements the Array API specification, while pdarray
itself could implement something more like numpy's API. (Array
needed to be a separate type, because there are places where the Array API deviates from numpy's API.)
I left a couple of comments about this, but haven't gone over all the changes yet:
81ee3df
to
2da970b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! only comment is on a duplicated helper function
Co-authored-by: drculhane <[email protected]>
781866e
to
ce64bac
Compare
This changes the functions zeros, ones, and full in pdarrayclass to return Array type in the multi dimensional case. It also adds some extra unit tests.
Closes #3699 zeros, ones, full to return Array