Skip to content

Commit

Permalink
minor clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
ajpotts committed Aug 28, 2024
1 parent 02f3296 commit 81ee3df
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions arkouda/pdarraycreation.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import numpy as np
import pandas as pd
from typeguard import typechecked

from arkouda.client import generic_msg, get_max_array_rank
from arkouda.numpy.dtypes import (
NUMBER_FORMAT_STRINGS,
Expand Down Expand Up @@ -218,7 +219,6 @@ def array(
>>> type(strings)
<class 'arkouda.strings.Strings'>
"""
# Removed @typechecked to prevent cyclic dependencies with Array
from arkouda.numeric import cast as akcast

# If a is already a pdarray, do nothing
Expand Down Expand Up @@ -308,15 +308,13 @@ def array(
# including the dtype and size. If the server has a different byteorder
# than our numpy array we need to swap to match since the server expects
# native endian bytes

aview = _array_memview(a)
rep_msg = generic_msg(
cmd=f"array<{a.dtype.name},{ndim}>",
args={"dtype": a.dtype.name, "shape": tuple(a.shape), "seg_string": False},
payload=aview,
send_binary=True,
)

return create_pdarray(rep_msg) if dtype is None else akcast(create_pdarray(rep_msg), dtype)


Expand Down Expand Up @@ -611,7 +609,6 @@ def full(
>>> ak.full(5, 5, dtype=ak.bool_)
array([True, True, True, True, True])
"""

if isinstance(fill_value, str):
return _full_string(size, fill_value)

Expand Down

1 comment on commit 81ee3df

@drculhane
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Looks right to me.

Please sign in to comment.