Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3417: Separate Parquet string read code from generic read function #3418

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

bmcdonald3
Copy link
Contributor

@bmcdonald3 bmcdonald3 commented Jul 9, 2024

Previously, the readColumnByName function included logic for handling strings directly within the function itself. This approach made it difficult to modify string-specific behavior because changes required updates to the entire function header across all call sites. Additionally, this approach made the code less clear as string handling logic was mixed with generic data type handling.

This pull request separates the string read code into a dedicated function. This improves code maintainability and readability by:

  • Isolating string-specific logic, making it easier to modify without affecting other data types.
  • Enhancing clarity by separating generic data type handling from string handling.

closes #3417

@bmcdonald3 bmcdonald3 requested a review from stress-tess July 9, 2024 23:04
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

src/parquet/ReadParquet.cpp Show resolved Hide resolved
@stress-tess stress-tess added this pull request to the merge queue Jul 9, 2024
Merged via the queue into Bears-R-Us:master with commit 2ca352c Jul 9, 2024
16 checks passed
@bmcdonald3 bmcdonald3 deleted the pq-string-seperate branch July 10, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Parquet string read code from generic read function
2 participants