Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Parquet string read code from generic read function #3417

Closed
bmcdonald3 opened this issue Jul 9, 2024 · 0 comments · Fixed by #3418
Closed

Separate Parquet string read code from generic read function #3417

bmcdonald3 opened this issue Jul 9, 2024 · 0 comments · Fixed by #3418
Assignees

Comments

@bmcdonald3
Copy link
Contributor

Previously, the readColumnByName function included logic for handling strings directly within the function itself. This approach made it difficult to modify string-specific behavior because changes required updates to the entire function header across all call sites. Additionally, this approach made the code less clear as string handling logic was mixed with generic data type handling.

This pull request separates the string read code into a dedicated function. This improves code maintainability and readability by:

  • Isolating string-specific logic, making it easier to modify without affecting other data types.
  • Enhancing clarity by separating generic data type handling from string handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant