Closes #3334, #3351: Simplify server side string code and added fixed length #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting that this PR should be merged after #3333 and rebased on top of that |
stress-tess
changed the title
stress-tess
reviewed
Jun 25, 2024
stonea
added a commit
to chapel-lang/chapel
that referenced
this pull request
Jul 3, 2024
Annotations --- - (#25140) introduced shared-memory bypass behavior that caused several perf. regressions, (#25307) helped resolve that somewhat by reverting some behavior. Arkouda annotations: - (Bears-R-Us/arkouda#3323) reverted a prior PR that caused a perf regression w/ dataframe indexing - (Bears-R-Us/arkouda#3335) and (Bears-R-Us/arkouda#3368) PR (and the fix) that incorrectly changed how the number of bytes were calculated for string IO benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to simplify the Parquet string reading code
to better understand the performance implications of
changes to that code, this PR switches back to the simpler
way of doing things and also adds a "fixed_len" arg on
the client side to skip byte calculation in cases where
the size of each string is known at runtime and
consistent in the entire file.
Additionally, the IO benchmark is updated to properly
handle strings for byte calculation.
Closes #3334
Fixes #3351