Reverts DataFrame Indexing Changes #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stress-tess
approved these changes
Jun 13, 2024
bmcdonald3
reviewed
Jun 13, 2024
bmcdonald3
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
array size = 10,000
number of trials = 1
>>> arkouda dataframe display
numLocales = 16, N = 160,000
_get_head_tail_server Average time = 0.9649 sec
_get_head_tail_server Average rate = 0.03 GiB/sec
_get_head_tail Average time = 1.9099 sec
_get_head_tail Average rate = 0.01 GiB/sec
Looks good
stonea
added a commit
to chapel-lang/chapel
that referenced
this pull request
Jul 3, 2024
Annotations --- - (#25140) introduced shared-memory bypass behavior that caused several perf. regressions, (#25307) helped resolve that somewhat by reverting some behavior. Arkouda annotations: - (Bears-R-Us/arkouda#3323) reverted a prior PR that caused a perf regression w/ dataframe indexing - (Bears-R-Us/arkouda#3335) and (Bears-R-Us/arkouda#3368) PR (and the fix) that incorrectly changed how the number of bytes were calculated for string IO benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of performance regressions, Ben and I determined that reverting the dataframe indexing updates was the best path forward to get a release out this week. This PR reverts those updates.
This should both fix the performance regressions and return the code base to a state where a
.valuescall is not needed on each DataFrame indexing call.Tested with CHPL_COMM={gasnet,none} for regular tests, proto tests, and benchmarks.