SegArray optimization & bug fix #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay initialization --- Signed-off-by: Brandon Neth <[email protected]>
bmcdonald3
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Cool, good catch! Just curious, do you have any performance runs you can put in the description so we have a sense of what kind of improvement to expect? An example of that would be something like #2290
stress-tess
approved these changes
Mar 11, 2024
|
Sure, these results are from my Mac. Average of 5 runs for 10k-element-long columns. Original version: .9077 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should improve the dataframe benchmark performance by removing two sources of redundant computation for SegArray columns. It also fixes a bug in the benchmark that only saved the result of the final run.
Both redundant computations appear in the SegArray initializer, which in my profiling contributed the most to the dataframe benchmark execution time. The first redundant computation occurred when calculating the number of non-empty segments, which was calculated both when setting the
_non_emptyfield and when counting them. The second redundant computation was the calculation of segment lengths, which occurs in thegen_rangesfunction, then again in theSegArrayinitializer. I added an optional argument togen_rangesto return the lengths to pass straight to the initializer instead of calculating it again during initialization.