Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2661: segarray.remove_repeats bug with empty segments #2861

Merged

Conversation

stress-tess
Copy link
Member

This PR (fixes #2661) fixes a bug in segarray.remove_repeats handling of empty segments. This was a very similar problem as in #2666

This PR (fixes Bears-R-Us#2661) fixes a bug in `segarray.remove_repeats` handling of empty segments. This was a very similar problem as in Bears-R-Us#2666
Copy link

@QuinsulonPhD QuinsulonPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks towards lack of knowledge of operation-- the logic appears sound.

@stress-tess stress-tess added this pull request to the merge queue Dec 6, 2023
Merged via the queue into Bears-R-Us:master with commit e4d6cb9 Dec 6, 2023
12 checks passed
@stress-tess stress-tess deleted the 2661_segarray_remove_repeats_bug branch December 11, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegArray.remove_repeats() Empty First Segment Incorrect Behavior
3 participants