Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SegArray.filter() Incorrect Behavior with Empty Segments #2666

Closed
Ethan-DeBandi99 opened this issue Aug 15, 2023 · 0 comments · Fixed by #2860
Closed

SegArray.filter() Incorrect Behavior with Empty Segments #2666

Ethan-DeBandi99 opened this issue Aug 15, 2023 · 0 comments · Fixed by #2860
Assignees
@stress-tess
Labels
bug Something isn't working

Comments

@Ethan-DeBandi99
Copy link
Contributor

SegArray.filter() appears to be dropping the segments that are empty before filtering. Empty segments resulting from the filter are handled properly.

# NOTE - uses function to build segarray components used in testing
a, b = self.build_repeat_filter_data(dtype)
segments = ak.array([0, len(a), len(a), len(a), len(a)+len(b)])
flat = ak.array(a + b)
sa = ak.SegArray(segments, flat)
result = sa.filter(3)
@Ethan-DeBandi99 Ethan-DeBandi99 added the bug Something isn't working label Aug 15, 2023
@stress-tess stress-tess self-assigned this Sep 8, 2023
stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Nov 24, 2023
Fixes Bears-R-Us#2666: Segarray.filter bug with empty segments
6baa7b8 
This PR (fixes Bears-R-Us#2666) fixes a bug where segarray.filter always dropped empty segments
@stress-tess stress-tess mentioned this issue Nov 24, 2023
Merged
stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Nov 24, 2023
Fixes Bears-R-Us#2661: segarray.remove_repeats bug with empty segments
215982d 
This PR (fixes Bears-R-Us#2661) fixes a bug in `segarray.remove_repeats` handling of empty segments. This was a very similar problem as in Bears-R-Us#2666
@stress-tess stress-tess mentioned this issue Nov 24, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2023
@stress-tess
Fixes #2666: Segarray.filter bug with empty segments (#2860)
e84cc74 
This PR (fixes #2666) fixes a bug where segarray.filter always dropped empty segments

Co-authored-by: Pierce Hayes <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2023
@stress-tess
Fixes #2661: segarray.remove_repeats bug with empty segments (#2861)
e4d6cb9 
This PR (fixes #2661) fixes a bug in `segarray.remove_repeats` handling of empty segments. This was a very similar problem as in #2666

Co-authored-by: Pierce Hayes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2666: Segarray.filter bug with empty segments stress-tess/arkouda
2 participants
@Ethan-DeBandi99 @stress-tess