Closes #2547, #2553, #2554, #2555 - setops_tests.py conversion for new test framework
#2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
hokiegeek2,
stress-tess,
jaketrookman and
TheOddCzar789
stress-tess
reviewed
Jul 7, 2023
stress-tess
reviewed
Jul 10, 2023
stress-tess
approved these changes
Jul 10, 2023
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2547, #2553, #2554, #2555
This PR converts the
setops_tests.pytesting for use in the new test framework. These tests have been updated to provide better coverage of the codebase for setops. This coverage exposed a few shortcomings within the existing setops. #2553, #2554, and #2555 were added to address these. All of the resolutions were simple and added within this PR.There may be some further simplification that can be done, so please let me know if you see anything.