Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ak.in1d not inverting results when invert=True #2554

Closed
Ethan-DeBandi99 opened this issue Jul 6, 2023 · 2 comments
Closed

ak.in1d not inverting results when invert=True #2554

Ethan-DeBandi99 opened this issue Jul 6, 2023 · 2 comments
Assignees
@Ethan-DeBandi99
Labels
bug Something isn't working

Comments

@Ethan-DeBandi99
Copy link
Contributor

While working issue #2547, it was discovered that in the multi-array case for processing of ak.in1d if the invert parameter is set to True, the invert is not occurring. This is resulting in incorrect results. The returns need to be updated to check if invert is set and in that case return the inverted truth array.
@Ethan-DeBandi99 Ethan-DeBandi99 added the bug Something isn't working label Jul 6, 2023
@Ethan-DeBandi99 Ethan-DeBandi99 self-assigned this Jul 6, 2023
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Jul 6, 2023
Closed
@Ethan-DeBandi99
Copy link
Contributor Author

Noting that this was also true for Categoricals in a special case.

@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Jul 7, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2023
@Ethan-DeBandi99
Closes #2547, #2553, #2554, #2555 - setops_tests.py conversion for …
8485527 
…new test framework (#2556)

* Adds setops testings. Corrects bugs found during test updates.

* removing unused import

* Updating based on review comments

* Final updates
@stress-tess
Copy link
Member

closed by #2556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-DeBandi99 Ethan-DeBandi99

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ethan-DeBandi99 @stress-tess