Closes #1783 - SegArray.__getitem__ to Server
#1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethan-DeBandi99
requested review from
reuster986,
stress-tess,
mhmerrill and
joshmarshall1
…to use JSON return for SegArrays. Adds from parts function to build segarray. Adds ak.segarray to build SegArray
Ethan-DeBandi99
force-pushed
the
1783_segarray_getitem
branch
from
23cad27 to
c9506d8
Compare
joshmarshall1
approved these changes
Sep 19, 2022
stress-tess
reviewed
Sep 19, 2022
arkouda/segarray.py
Outdated
| if len(d) != 1: | ||
| raise ValueError("All columns must have same dtype") | ||
| dtype = d.pop() | ||
| newsegs = arange(size) * n |
There was a problem hiding this comment.
for the pdarray case is every element of the pdarray its own segment?
There was a problem hiding this comment.
No the pdarray indicates when segments to access. For example, ak.array([1,3]) would return a SegArray containing segments 1 and 3 of the original.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1783
Closes #1708
SegArrayindexing to the server and updates__getitem__to use server messages for indexing. The majority of the indexing logic was modeled fromSegString.OutOfBoundsErrortoServerErrors.chplbecause 2 modules are not utilizing thisSegArraycreation response messages to be formatted as JSON. These messages also now return thecreatestatements for thevalues,segments, andlengthspdarray components so that subsequent server calls are not required for access.ak.SegArray.from_parts. This operates as the__init__previously did. The__init__method has been updated to buildSegArrayfrom the response message components. This was modeled afterSegmentedStringsclient side code.ak.segarraymethod to ease the transition to this update for users. This is an alias toak.SegArray.from_partsbut the syntax resembles the creation of pdarrays viaak.arrayand only requires case changes in existing code.