-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2432 - Revert SegArray to Client Side #2439
Closes #2432 - Revert SegArray to Client Side #2439
Conversation
… parquet writes and attach/register updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things to look at. The only big one is registration is gonna need a bit of reworking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple comments re: slots
Closes #2432
This code "reverts" SegArray to a client only implementation. This required some modification to maintain functionality that was added that took advantage of the
SegArraySymEntry
. This implementation should provide more flexibility moving forward and relieve some memory pressure that could be caused by the Server side implementation.ak.segarray
andak.SegArray.from_parts
. These will be maintained for at least 1 release cycle with deprecation warnings.__init__
method to take insegments
andvalues
withlengths
andgrouping
as optional parameters{"segments": segarray.segments.name, "values": segarray.values.name}
. Server side workflows updated where applicable.segments
andvalues
are registered now. This prevents storage of 2 additional objects that can be recomputed on attach.src/SegmentedArray.chpl
DeletedSegArraySymEntry
class removed