Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2432 - Revert SegArray to Client Side #2439

Merged

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #2432

This code "reverts" SegArray to a client only implementation. This required some modification to maintain functionality that was added that took advantage of the SegArraySymEntry. This implementation should provide more flexibility moving forward and relieve some memory pressure that could be caused by the Server side implementation.

  • Deprecates ak.segarray and ak.SegArray.from_parts. These will be maintained for at least 1 release cycle with deprecation warnings.
  • Updates the __init__ method to take in segments and values with lengths and grouping as optional parameters
  • Moves SegArray indexing code back to the client. The client side implementation also prevents duplicate arrays from being generated on the server. This should alleviate some memory pressure. If users desire we can add a flag to allow them to create copies when generating the SegArray in order to maintain the original objects used for creation.
  • Updates SegArray related IO workflows to account for there no longer being a SegArray server object. These are now handled as a segments and values array.
  • Updates message configuration to send SegArray objects as {"segments": segarray.segments.name, "values": segarray.values.name}. Server side workflows updated where applicable.
  • Register/attach code updated. Only segments and values are registered now. This prevents storage of 2 additional objects that can be recomputed on attach.
  • src/SegmentedArray.chpl Deleted
  • SegArraySymEntry class removed

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to look at. The only big one is registration is gonna need a bit of reworking

arkouda/message.py Outdated Show resolved Hide resolved
arkouda/segarray.py Outdated Show resolved Hide resolved
arkouda/segarray.py Show resolved Hide resolved
arkouda/segarray.py Outdated Show resolved Hide resolved
src/HDF5Msg.chpl Outdated Show resolved Hide resolved
src/ParquetMsg.chpl Outdated Show resolved Hide resolved
src/RegistrationMsg.chpl Outdated Show resolved Hide resolved
src/RegistrationMsg.chpl Outdated Show resolved Hide resolved
tests/registration_test.py Outdated Show resolved Hide resolved
tests/util_test.py Outdated Show resolved Hide resolved
@hokiegeek2 hokiegeek2 self-requested a review May 24, 2023 18:11
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@hokiegeek2 hokiegeek2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple comments re: slots

arkouda/message.py Show resolved Hide resolved
arkouda/message.py Show resolved Hide resolved
@stress-tess stress-tess enabled auto-merge May 24, 2023 18:39
@stress-tess stress-tess added this pull request to the merge queue May 24, 2023
@hokiegeek2 hokiegeek2 self-requested a review May 24, 2023 18:53
Merged via the queue into Bears-R-Us:master with commit aac8abb May 24, 2023
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 2432_segarray_client_side branch May 24, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert SegArray to Client Side Object Only
4 participants