Closes #1573: Remove python script generation for Chapel unit tests #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CommandMap.chpl` for some reason had a `use ServerRegistration` that I believe was added by accident and that was making the Chapel unit tests need the `ServerRegistration` script to be generated. This PR removes that unnecessary `use` and takes out the python script call from the CI and Chapel unit tests.
stress-tess
changed the title
stress-tess
approved these changes
Jul 11, 2022
Ethan-DeBandi99
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandMap.chplfor some reason had ause ServerRegistrationthat I believe was added by accident and that was making the
Chapel unit tests need the
ServerRegistrationscript to begenerated. This PR removes that unnecessary
useand takes outthe python script call from the CI and Chapel unit tests.
Closes #1573