Closes #1161: Update make test-chapel to run unit tests
#1561
Conversation
This PR (Closes Bears-R-Us#1161): - Updates `make test-chapel` to run unit tests in addition to compiling them - This now calls the same commands the CI uses to run i.e. ```bash python3 src/serverModuleGen.py ServerModules.cfg start_test test ``` NOTE: I'm not the best with `make`, so please feel free to suggest a different approach. I got this working using `.SILENT:` but that feels like overkill. I think we really just need `no-print-directory`, but I'm not sure how to get that to work. Without the silent, `make` will exclaim everytime it switches into the test directory and that interupts the compile statement
stress-tess
requested review from
ronawho,
Ethan-DeBandi99,
mhmerrill,
jeichert60 and
joshmarshall1
| test-chapel: $(TEST_TARGETS) | ||
| .SILENT: | ||
| test-chapel: | ||
| @echo $(shell python3 $(MODULE_GENERATION_SCRIPT) $(ARKOUDA_CONFIG_FILE)); |
There was a problem hiding this comment.
So far as I know the chapel tests don't need the config file, why is this generation needed?
There was a problem hiding this comment.
I don't know if they do. I basically was just following along with what we do for our testing in the CI
arkouda/.github/workflows/CI.yml
Lines 151 to 153 in 9f9042b
There was a problem hiding this comment.
Looks like it was added in e622dc5 -- @bmcdonald3 can you take an action item to look into whether this is needed.
There was a problem hiding this comment.
Looked into this; it turns out that CommandMap.chpl had an unnecessary use ServerRegistration for some reason that was causing the python script to be called first. I've opened #1575 to fix this.
There was a problem hiding this comment.
I don't think the line that @ronawho was saying may not be required will hurt anything by being there. I do want to note a few things to see if anyone else thinks they are an issue
- The .SILENT appears to be causing the compile statements to disappear during
make. Not sure if this is an issue, but may make debugging more of a pain. - I am seeing a failure during
test/UnitTestParquetCpp.chpl. This is also happening for me on master. Good chance it may be due to my configuration, but wanted note in case anyone else is seeing it. Below is the output from the.tmp
timedexec: target program died with signal 11, without coredump
|
I did a bit more digging on the issue I was seeing with the |
On Friday, I had Jim run the test as well and it failed there. Thus it appears that this is an issue with the arm64 chipset when running the parquet test. I will try to find some time this week to look into it, and will probably want to touch base with @bmcdonald3 since he wrote our current Parquet code. |
This PR (Closes #1161):
make test-chapelto run unit tests in addition to compiling thempython3 src/serverModuleGen.py ServerModules.cfg start_test testNOTE:
I'm not the best with
make, so please feel free to suggest a different approach. I got this working using.SILENT:but that feels like overkill. I think we really just needno-print-directory, but I'm not sure how to get that to work. Without the silent,makewill exclaim everytime it switches into the test directory and that interupts the compile statementTagging @mhmerrill, @bmcdonald3, and @ronawho as they are better with
makethan me