Closes #1282 SegArray Register/Attach #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g from these features because groupby does not yet support them. Added testing to validate functionality.
Ethan-DeBandi99
force-pushed
the
1282_segarray_reg_att
branch
from
f142cc2 to
9078ead
Compare
stress-tess
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #1282):
attach,registerandunregisterfunction intoak.SegArray.groupingsinceak.GroupBydoes not support these functions. Issue Attach Grouping Element in SegArray #1319 is tracking adding this back to prevent it from being recomputed.