Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach Grouping Element in SegArray #1319

Closed
Ethan-DeBandi99 opened this issue Apr 22, 2022 · 1 comment
Closed

Attach Grouping Element in SegArray #1319

Ethan-DeBandi99 opened this issue Apr 22, 2022 · 1 comment
Assignees
@joshmarshall1
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ethan-DeBandi99
Copy link
Contributor

GroupBy does not currently have attach, register or unregister functionality. It is being worked in issue #1122. ak.SegArray attach, register and unregister functionality is being added through issue #1282. Once the code for both issues have been merged, we need to update the ak.SegArray functionality to deal with the grouping property instead of recomputing it. The code has comments with TODO tags indicating what is to be done.
@Ethan-DeBandi99 Ethan-DeBandi99 added the enhancement New feature or request label Apr 22, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Apr 22, 2022
Merged
@joshmarshall1 joshmarshall1 added the good first issue Good for newcomers label May 3, 2022
@Ethan-DeBandi99
Copy link
Contributor Author

This was added previously. However, PR #2432 removes it in an attempt to reduce memory pressure since it can be easily recomputed. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshmarshall1 joshmarshall1

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ethan-DeBandi99 @joshmarshall1