Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dropna option to dataframe.GroupBy #2894

Closed
ajpotts opened this issue Jan 5, 2024 · 0 comments · Fixed by #2904
Closed

add dropna option to dataframe.GroupBy #2894

ajpotts opened this issue Jan 5, 2024 · 0 comments · Fixed by #2904
Assignees
@ajpotts
Labels
enhancement New feature or request

Comments

@ajpotts
Copy link
Contributor

ajpotts commented Jan 5, 2024

dataframe.GroupBy should have an option dropna, with default dropna=True to match pandas api:

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.groupby.html
@ajpotts ajpotts added the enhancement New feature or request label Jan 5, 2024
@ajpotts ajpotts mentioned this issue Jan 8, 2024
Merged
@ajpotts ajpotts self-assigned this Jan 9, 2024
@stress-tess stress-tess mentioned this issue Jan 10, 2024
Closed
12 tasks
ajpotts added a commit to ajpotts/arkouda that referenced this issue Jan 17, 2024
@ajpotts
Closes Bears-R-Us#2894 add dropna option to dataframegroupby
3adc825
ajpotts added a commit to ajpotts/arkouda that referenced this issue Jan 17, 2024
@ajpotts
Closes Bears-R-Us#2894 add dropna option to dataframe groupby
93ca19e
ajpotts added a commit to ajpotts/arkouda that referenced this issue Jan 17, 2024
@ajpotts
Closes Bears-R-Us#2894 add dropna option to dataframe groupby
4d145a3
@ajpotts ajpotts linked a pull request Jan 17, 2024 that will close this issue
Closes #2894 add dropna option to dataframe groupby #2904
Merged
ajpotts added a commit to ajpotts/arkouda that referenced this issue Jan 17, 2024
@ajpotts
Closes Bears-R-Us#2894 add dropna option to dataframe groupby
ee9f1f3
github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2024
@ajpotts
Closes #2894 add dropna option to dataframe groupby (#2904)
fc852ff 
* Closes #2894 add dropna option to dataframe groupby

* run black to reformat

* removed unnecessary comments

* remove dropna from attribute section of pydocs for DataFrame.GroupBy, as it is an attribute of DataFrame.GroupBy.gb instead

* change __ functions to _ functions to match team coding style.

---------

Co-authored-by: Amanda Potts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajpotts ajpotts

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2894 add dropna option to dataframe groupby ajpotts/arkouda
1 participant
@ajpotts