Closes ticket #2831 to align dataframe.groupby().size(), dataframe.groupby().sum() to pandas #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unsuported in python 3.8
…one, and return series when as_index=True and as_series=None
stress-tess
reviewed
Jan 8, 2024
jaketrookman
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket changes DataFrame.GroupBy.size() to be more similar to the pandas API. It will now return a dataframe as default, with an as_series optional parameter to allow a series to be returned.
The groupby count operation was temporarily set to be an alias of size both in dataframe.GroupBy.count() and groupbyclass.GroupBy.count().
In dataframe.py, def _make_aggop returns an aggregate function, such as dataframe.GroupBy.sum(). The output has been changed to return a dataframe.DataFrame object as default, with an optional parameter as_series to return a Series object instead. The groupby column names have been added as well.
dataframe.GroupBy also now has additional parameters gb_key_names=None, as_index=True. The gb_key_names allow storage of the key names of the columns used to group by, and the as_index parameter allows the user to select whether the group by column will be used as the index in the returned dataframe.DataFrame or series.Series.