Fix #405 , and both new and corrected tests for JsonGenerator #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to run current tests
side effect: improves code coverage
introduces a test which fails as it correctly identifies an issue with the current code
…orrectly Modified isDataCached to compare both keys and value types in the schema to ensure cache invalidation when field types change. This resolves the issue where changing a field type (e.g., from int to firstName) did not update the preview as expected.
…nd setting its type in CardForm
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
TobyDS
changed the title
Bashamega
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds and corrects current tests for JsonGenerator. This pull request also identifies and fixes an issue with the current code where changing a field type does not cause the cache to be invalidated.
Fixes #(405)
Adds to #(383)
Type of change
Checklist:
Screenshots (if applicable):